Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support @hapi/hapi #1108

Merged
merged 1 commit into from
Sep 3, 2019
Merged

feat: support @hapi/hapi #1108

merged 1 commit into from
Sep 3, 2019
+47 −25

Conversation

kjin
Copy link
Contributor

@kjin kjin commented Aug 26, 2019 •
edited
Loading

Fixes #1107

This PR adds support for hapi 18 (now @hapi/hapi).

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 26, 2019
@codecov
Copy link

codecov bot commented Aug 27, 2019

Codecov Report

Merging #1108 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1108      +/-   ##
==========================================
+ Coverage   94.99%   94.99%   +<.01%     
==========================================
  Files          98       98              
  Lines        6450     6451       +1     
  Branches      499      500       +1     
==========================================
+ Hits         6127     6128       +1     
  Misses        166      166              
  Partials      157      157
Impacted Files Coverage Δ
src/plugins/plugin-hapi.ts 92% <ø> (ø) ⬆️
src/config.ts 100% <ø> (ø) ⬆️
test/test-trace-web-frameworks.ts 98.83% <100%> (ø) ⬆️
test/test-config-plugins.ts 100% <100%> (ø) ⬆️
test/web-frameworks/hapi17.ts 92.68% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84f9229...3baf3a8. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Aug 27, 2019 •
edited
Loading

Codecov Report

Merging #1108 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1108      +/-   ##
==========================================
+ Coverage   94.99%   94.99%   +<.01%     
==========================================
  Files          98       98              
  Lines        6450     6451       +1     
  Branches      499      500       +1     
==========================================
+ Hits         6127     6128       +1     
  Misses        166      166              
  Partials      157      157
Impacted Files Coverage Δ
src/plugins/plugin-hapi.ts 92% <ø> (ø) ⬆️
src/config.ts 100% <ø> (ø) ⬆️
test/test-trace-web-frameworks.ts 98.83% <100%> (ø) ⬆️
test/test-config-plugins.ts 100% <100%> (ø) ⬆️
test/web-frameworks/hapi17.ts 92.68% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84f9229...3baf3a8. Read the comment docs.

@kjin kjin marked this pull request as ready for review August 27, 2019 17:05
@kjin kjin requested a review from a team August 27, 2019 17:05
@soldair soldair self-requested a review September 3, 2019 21:31
soldair
soldair approved these changes Sep 3, 2019
View reviewed changes
Copy link
Contributor

@soldair soldair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kjin kjin merged commit d545e93 into googleapis:master Sep 3, 2019
@release-please release-please bot mentioned this pull request Jun 30, 2022
Merged
@WontonSam WontonSam mentioned this pull request Sep 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soldair soldair soldair approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support hapi@18
3 participants
@kjin @soldair @googlebot